-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure throttle level is always set fixes bug 731325 #459
Ensure throttle level is always set fixes bug 731325 #459
Conversation
Please run check.py on all your Python files: there are a bunch of styling problems that it will raise. |
@@ -84,3 +84,133 @@ How to configure your test environment | |||
soccoro. E.g if you have installed socorro at | |||
``/home/tester/Mozilla/socorro`` then your PYTHONPATH should look like | |||
``...:/home/tester/Mozilla:/home/tester/Mozilla/thirdparty:...`` | |||
|
|||
Writing a PostgreSQL middleware unit test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think the "Writing a test" part should go into addaservice instead. Or at least there should be a link there to here, as it is really middleware-related.
@AdrianGaudebert changes made, please let me know if there is more or, if I missed something |
from socorro.lib import datetimeutil | ||
import socorro.unittest.testlib.util as testutil | ||
|
||
from unittestbase import PostgreSQLTestCase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a point before unittestbase so we know it comes from the same directory and is not a global Python module.
from .unittestbase import PostgreSQLTestCase
Code is good and tested, doc needs a bit of work before I r+. |
Latest documentation changes made and PR updated |
r+ Excellent work Schalk, thank you! |
…ong-731325 Ensure throttle level is always set fixes bug 731325
This pull request also includes some documentation on writing and running unit tests.